Fix Tile Overlay with premixed pileup (ATLASSIM-3853)

In Overlay job TileRawChannelContainer is used to check DQ status,
but in this case it is supposed that real data are used for overlay
and this container is always available.
In the case of MC this container is available but it is useless though it's harmless.
In the case of premixed data this container is not available at all.

Compilation warnings are fixed also.


Former-commit-id: 10032d031c43f6524d92dc3fa9e179458192ff19

TileCalorimeter/TileSimAlgs/src/TileDigitsMaker.cxx

@@ -511,8 +511,13 @@ StatusCode TileDigitsMaker::execute() {
     } else {
       ATH_MSG_DEBUG( "TileRawChannelContainer for DQ check retrieved");
     }
-    TimedRawChanContList::iterator iTzeroRawChanCont(rawchanContList.begin());
-    const TileRawChannelContainer * rndm_rawchan_container = (iTzeroRawChanCont->second);
+
+    const TileRawChannelContainer* rndm_rawchan_container(nullptr);
+    if (!rawchanContList.empty()) {
+      TimedRawChanContList::iterator iTzeroRawChanCont(rawchanContList.begin());
+      rndm_rawchan_container = iTzeroRawChanCont->second;
+    }
+
     ATH_MSG_DEBUG( "setContainer method being called in TileDigitsMaker");
     m_beamInfo->setContainers(rndm_digit_container, rndm_rawchan_container);
     ATH_MSG_DEBUG( "Containers successfully set in TileBeamInfoProvider");

TileCalorimeter/TileSimAlgs/src/TileHitVecToCntTool.cxx

@@ -478,7 +478,7 @@ void TileHitVecToCntTool::processHitVectorForPileUp(const TileHitVector* inputHi
     eHitTot += ener;
 
     TileHit * pHit = m_allHits[hit_idhash];
-    TileHit * pHit_DigiHSTruth;
+    TileHit * pHit_DigiHSTruth(nullptr);
     if(m_doDigiTruth) pHit_DigiHSTruth = m_allHits_DigiHSTruth[hit_idhash];
 
     if (0 == pHit) {
@@ -935,7 +935,7 @@ StatusCode TileHitVecToCntTool::mergeEvent() {
 
     for (; iHit != lastHit; ++iHit) {
       TileHit *pHit = (*iHit);
-      TileHit *pHit_DigiHSTruth;
+      TileHit *pHit_DigiHSTruth(nullptr);
       if(m_doDigiTruth) pHit_DigiHSTruth = new TileHit(**iHit_DigiHSTruth);
       if (pHit->size() > 1 || pHit->energy() != 0.0) {       // hit exists
         m_hits->push_back(pHit);   // store hit in container