Fix warnings about regexp syntax.

Frank Berghaus authored 4 years ago and Walter Lampl committed 4 years ago

Move meta-data test suite into RecExRecoTest as discussed at the core
meeting. Use a configuration class to manage how to run the transforms
and test metadata. Allow user to specify inputs and references.

Should now use [], not (), to supply template parameters.

Ignore a few custom targets in cmake_depends. Also use LCG_97a as an
alternative source for pygraphviz.

Scott Snyder authored 4 years ago and Adam Edward Barton committed 4 years ago

With python 3.8, the hacks used in pythonize_read_root_file lead to heap
corruption.  Rework to avoid this.

We're rather constrained since this has to work with both py2 and 3,
so the way it's done here is a bit roundabout and ineffecient.
Once we drop py2, this can be done much better by simply
having read_root_file return a PyBytes object

Fix previous fix to avoid changing behavior with python 2.

Delete `cmake.newanalysisalg`, `cmake.newpkg`, `cmake_newskeleton` and
`cmt_newjobo` helper commands. They were outdated and not clear anybody
is using them. If yes, they can be updated/resurrected.

Fixes ATLASG-1414.

Frank Berghaus authored 4 years ago and Walter Lampl committed 4 years ago

Emit an information message if no differences are found. Also handle
exceptional circumstance of one of the input files not existing.

Frank Winklmeier authored 4 years ago and Walter Lampl committed 4 years ago

Delete unused fileutils, path and merge_join modules. Also delete pep8
and avn alias. The pep8 script is superseded by flake8. And the avn
alias was pointing to a non-existent script.

92cf019e

Delete the `gen/load_typeregistry_dso` functions that could create/load a
`typereg_dso_db.csv` file with type information. However, the generate
function currently just creates an empty file and thus this code seems
no longer necessary.

Delete `castor` and `rfio` modules. Those are not used anywhere and
castor is dead.

Add `acmd cmake depends` sub-command to show package/target
dependencies. This script relies on the `packages.dot` file that needs
to be produced during release building via `cmake --graphviz`.

Relates to ATLINFR-3561.

Delete unused third-party modules: `pshell`, `reimport`, `smem`

In most cases it is not necessary to load all plugins as the user very
likely specified one on the command line. Try to first load a specific
plugin and then fall back to loading all of them. This reduces the
startup time significantly, i.e. if we keep adding new sub-commands.

Also remove the "running sub-command" INFO message as this makes it
impossible to implement sub-commands that can be used in pipes.

SetSize is being renamed to reshape.
Avoids a root deprecation warning.

Frank Berghaus authored 4 years ago and Adam Edward Barton committed 4 years ago

Take the functionality of the meta-diff utility and abstract it into a
module. This will allow other python scripts to use this functionality
transparetly. The executable is not only in charge of handling command
line arguments and calling the module's main function.

This reverts merge request !32937

When we run aclic, root produces a DSO and tries to link it.
As past of this, ROOT tries to find all the libraries that the new
DSO depends on by listing all its symbols and then walking through
all libraries on LD_LIBRARY_PATH to find a definition.
Due to a bug, cling will crash if it encounters a separate-debug
library in doing so.  Pretty much every library contains
the gprof stub __gmon_start__ as a hidden weak symbol.
Cling ends up searching for this symbol, and since it is hidden,
it will end up trying all libraries.  In Athena builds, it eventually
hits a debug library and dies.

Work around by injecting a dummy defintion of __gmon_start__.

Fixes unit test failure in master.

Second fix, more general, should help with ATR-20928 too

The importhook by itself was OK, but in some cases it would cause
a crash in XML parsing due to 2 conflicting copies of pyexpat.so in LCG_96

Michele Renda authored 5 years ago and Frank Winklmeier committed 5 years ago

This reverts commit 3a6b413eda7b3217b6972b2f80b56dd24e1d2a5d.

    
Work around pyroot issue with getting trailing garbage when accessing
a string stored in a tree.   This can confuse the bytes->unicode conversion
resulting in a crash.

If the forking decorator handles an exception in the child, make
sure we flush before exiting.  Otherwise the stack trace may get lost.

In AthFile, fail gracefully if the metadata tree is missing.