PixelConditionsAlgorithms: Clean up conditions dependencies.

See merge request atlas/athena!33986

SGTools: Fix cppcheck warning.

See merge request atlas/athena!33978

MagFieldServices: Clean up conditions dependency.

See merge request atlas/athena!33989

CxxUtils: Suppress cppcheck warning.

See merge request atlas/athena!33981

InDetTrackHoleSearch: cmake fixes

See merge request atlas/athena!33994

StoreGate: Fix cppcheck warnings.

See merge request atlas/athena!33980

AthenaPoolCnvSvc: cppcheck fixes

See merge request atlas/athena!33979

SGComps: Fix cppcheck warnings.

See merge request atlas/athena!33977

PyUtils: Fix use of deprecated pyroot syntax.

See merge request atlas/athena!33976

IOVSvc: Fix refcounting bug in createCondObj

See merge request atlas/athena!33975

Acts mat map

See merge request atlas/athena!33280

Improvements for re-reco from ESD

See merge request atlas/athena!33852

    
Library dependency fixes.

Don't declare a dependency on the DCS conditions folder if we're
not going to use it.

Don't declare a conditions dependency that we won't use.

Suppress new warning from cppcheck 2.0.

 - Move DataHandle comparison functions inline.
 - Don't pass large objects by value.
 

 - Use starts_with instead of find()==0.
 - Use prefix ++ rather than postfix.
 

Annotate throw function as noreturn.

 - Parameter name ordering mismatch.
 - Use preincrement rather than postincrement.
 

Should now use [], not (), to supply template parameters.

CondAttrListCollection is a DataObject with a reference count.
CondAttrListCollAddress holds an instance of CondAttrListCollection
and manages its reference count.

However, what createCondObj does is to take the address, get the
DataBucket from the address, take control of the underlying
object via relinquish, and then store the underlying object
in the CondCont.  CondCont then takes ownership of the object,
and it doesn't know about refcounting.  Then finally the address
is deleted.  Normally this works ok even for CondAttrListCollection,
since when we get the object from the address the refcount
is incremented.  Deleting the address will then just decrement
the reference count again, and the CondCont is left as the
only owner of the object.

But the range being inserted entirely overlaps with an existing range,
then CondCont will delete the object rather than inserting it.
In that case, when we try to delete the object, it tries to
decrement the object's refcount using a dangling reference 
to the deleted object, which can crash.

Fix this by making sure that the address is deleted before
we try to add the object to the CondCont.

Revert "Merge branch 'menumt_cleanup' into 'master'"

See merge request atlas/athena!33968

TrigTauRec monitoring cleanup

See merge request atlas/athena!33859

Restructure HLTMenu JSON

See merge request atlas/athena!33614

This reverts merge request !33843

Add ATLAS_CHECK_THREAD_SAFETY to InDetRegionSelector and MuonRegionSelector...

See merge request atlas/athena!33858

Tracking geometry conditions alg

See merge request atlas/athena!32418

Copy changes in PMGTools from 21.2 into master and make it compile

See merge request atlas/athena!33864

Tim Herrmann authored 4 years ago and Adam Edward Barton committed 4 years ago

renamed private variables _flt_channel_number and fStoreSampleInfo (member variable) to meet naming conventions

AthenaMonitoring add l1calo monitoring python flags

See merge request atlas/athena!32879

Sweep to master: fixNSWSegmentCleaner

See merge request atlas/athena!33950

Add ATLAS_CHECK_THREAD_SAFETY to InDetTestBLayer.

See merge request atlas/athena!33944

PyUtils: Ignore custom targets in cmake_depends

See merge request atlas/athena!33945

Add ATLAS_CHECK_THREAD_SAFETY to BCM_Digitization.

See merge request atlas/athena!33943

CaloRec: Rework CaloClusterCorrDumper to not use ToolWithConstantsMixin.

See merge request atlas/athena!33813

AthContainers+xAODCore: Fix cppcheck warnings.

See merge request atlas/athena!33941