Skip to content
Snippets Groups Projects
Select Git revision
  • main-ATDAQPPES-16-25
  • main-ATDAQPPES-16-24
  • main-ATDAQPPES-16-23
  • main-ATDAQPPES-16-22
  • main-ATDAQPPES-16-21
  • main-ATDAQPPES-16-20
  • main-ATDAQPPES-16-19
  • main-ATDAQPPES-16-18
  • main-ATDAQPPES-16-17
  • main-ATDAQPPES-16-16
  • main-ATDAQPPES-16-14
  • main-ATDAQPPES-16-13
  • main-ATDAQPPES-16-11
  • main-ATDAQPPES-16-12
  • main-ATDAQPPES-16-10
  • main-ATDAQPPES-16-9
  • main-ATDAQPPES-16-8
  • main-ATDAQPPES-16-7
  • main-ATDAQPPES-16-6
  • main-ATDAQPPES-15-1
  • nightly/master/2018-12-19T2001
  • nightly/master/2018-12-19T2143
  • nightly/master/2018-12-19T2258
  • nightly/master/2018-12-19T2259
  • nightly/21.2/2018-12-20T0018
  • nightly/21.2/2018-12-20T0324
  • nightly/21.2/2018-12-20T0332
  • nightly/21.6/2018-12-19T2218
  • nightly/21.0/2018-12-19T1952
  • nightly/21.0/2018-12-19T2121
  • nightly/21.0/2018-12-19T2159
  • nightly/21.0/2018-12-19T2250
  • nightly/21.2/2018-12-19T0018
  • nightly/21.2/2018-12-19T0324
  • nightly/21.2/2018-12-19T0331
  • nightly/21.2/2018-12-19T0333
  • nightly/master/2018-12-18T2000
  • nightly/master/2018-12-18T2143
  • nightly/master/2018-12-18T2257
  • nightly/master/2018-12-18T2351
40 results
Search by author
  • Any Author
  • ATLAS Robot ATLAS Robot atlasbot
  • Peter Sherwood peter
  • Tim Martin Tim Martin tamartin
3 authors
  1. Jun 22, 2020
  3. Jun 20, 2020
    • scott snyder's avatar
      SGComps: Fix cppcheck warnings. · c33d3dff
      scott snyder authored 
       - Parameter name ordering mismatch.
 - Use preincrement rather than postincrement.
      c33d3dff
    • scott snyder's avatar
      PyUtils: Fix use of deprecated pyroot syntax. · e054c5c0
      scott snyder authored 
      Should now use [], not (), to supply template parameters.
      e054c5c0
    • scott snyder's avatar
      IOVSvc: Fix refcounting bug in createCondObj · a2cb9afe
      scott snyder authored 
      CondAttrListCollection is a DataObject with a reference count.
CondAttrListCollAddress holds an instance of CondAttrListCollection
and manages its reference count.

However, what createCondObj does is to take the address, get the
DataBucket from the address, take control of the underlying
object via relinquish, and then store the underlying object
in the CondCont.  CondCont then takes ownership of the object,
and it doesn't know about refcounting.  Then finally the address
is deleted.  Normally this works ok even for CondAttrListCollection,
since when we get the object from the address the refcount
is incremented.  Deleting the address will then just decrement
the reference count again, and the CondCont is left as the
only owner of the object.

But the range being inserted entirely overlaps with an existing range,
then CondCont will delete the object rather than inserting it.
In that case, when we try to delete the object, it tries to
decrement the object's refcount using a dangling reference 
to the deleted object, which can crash.

Fix this by making sure that the address is deleted before
we try to add the object to the CondCont.
      a2cb9afe
  5. Jun 19, 2020