Eric Torrence authored 4 years ago and Edward Moyse committed 4 years ago

Several updates of iLumiCalc and associated scripts and html files
have been updated for the atlas-lumicalc website without ever being
committed back to the git master.  This patch brings the git master
back into sync with the code on the website, and provides bugfixes
for iLumiCalc that had been deployed on the website.

cleanup TrigL2MuonSA package v4

See merge request atlas/athena!33888

Define enums for DCS state word in SCT_DCSConditionsStatCondAlg for easier understanding.

See merge request atlas/athena!33886

Add ATLAS_CHECK_THREAD_SAFETY to InDetServMatGeoModel package with fixing some constness problems.

See merge request atlas/athena!33887

Remove unnecessary include or forward declaration of IRegSelSvc

See merge request atlas/athena!33866

TrigPSC: Suppress thread-safety checker warning.

See merge request atlas/athena!33992

AthenaKernel: Helpers for conditions access from python.

See merge request atlas/athena!33873

tauRecTools: move TauPi0ClusterScaler to src

See merge request atlas/athena!33934

tauRecTools: skip TauEleOLRDecorator in AnalysisBase

See merge request atlas/athena!33928

SiCombinatorialTrackFinderTool_xk: Clean up conditions dependencies.

See merge request atlas/athena!33988

TrkParticleCreator: Use summary rather than createSummary.

See merge request atlas/athena!33993

SiSPSeededTrackFinder: Clean up conditions dependencies.

See merge request atlas/athena!33987

SCT_ConditionsAlgorithms: Fix broken conditions dependencies in tests.

See merge request atlas/athena!33982

PixelConditionsAlgorithms: Clean up conditions dependencies.

See merge request atlas/athena!33986

SGTools: Fix cppcheck warning.

See merge request atlas/athena!33978

MagFieldServices: Clean up conditions dependency.

See merge request atlas/athena!33989

CxxUtils: Suppress cppcheck warning.

See merge request atlas/athena!33981

InDetTrackHoleSearch: cmake fixes

See merge request atlas/athena!33994

StoreGate: Fix cppcheck warnings.

See merge request atlas/athena!33980

AthenaPoolCnvSvc: cppcheck fixes

See merge request atlas/athena!33979

SGComps: Fix cppcheck warnings.

See merge request atlas/athena!33977

PyUtils: Fix use of deprecated pyroot syntax.

See merge request atlas/athena!33976

IOVSvc: Fix refcounting bug in createCondObj

See merge request atlas/athena!33975

Acts mat map

See merge request atlas/athena!33280

Improvements for re-reco from ESD

See merge request atlas/athena!33852

    
Library dependency fixes.

Use the summary method from the track summary tool rather than createSummary,
to avoid warnings from the thread-safety checker.

An uncoming change to the thread-safety checker will generate warnings
for virtual calls to unsafe functions.

This then gets a warning for the call to ITrigEventLoopMgr::prepareForRun
in Psc::prepareForRun.  Perhaps that latter function should also be marked
NOT_THREAD_SAFE, but that's awkward since the base class defining this
interface is in hltinterface.

Just suppress the warning for now.

Don't declare a dependency on the DCS conditions folder if we're
not going to use it.

Don't declare conditions dependencies that won't be used.

Don't declare conditions dependencies that won't be used.

Don't declare a conditions dependency that we won't use.

Don't request conditions dependencies that don't exist.

Suppress new warning from cppcheck 2.0.

 - Move DataHandle comparison functions inline.
 - Don't pass large objects by value.
 

 - Use starts_with instead of find()==0.
 - Use prefix ++ rather than postfix.
 

Annotate throw function as noreturn.

 - Parameter name ordering mismatch.
 - Use preincrement rather than postincrement.
 

Should now use [], not (), to supply template parameters.