Tommaso Lari authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

removed obsolete test from ISF_Validation

TrigT1Result: vector bounds checks.

See merge request !76775

Scott Snyder authored 2 months ago and Jiri Masik committed 2 months ago

TrigT1Result: vector bounds checks.

Protect against out-of-bounds vector reads.

TrackParticleCnvAlg: Fix when running in BStoRDO step

See merge request atlas/athena!76697

TrkDetDescrSvc: Fix out-of-bounds vector write.

See merge request !76773

Scott Snyder authored 2 months ago and Duc Ta committed 2 months ago

TrkDetDescrSvc: Fix out-of-bounds vector write.

reserve/resize confusion.
Fixes crash with -D_GLIBCXX_ASSERTIONS.

MuonEventTPCnv: Fix out-of-bounds vector accesses in tests.

See merge request !76774

Scott Snyder authored 2 months ago and Duc Ta committed 2 months ago

MuonEventTPCnv: Fix out-of-bounds vector accesses in tests.

Some dummy DD objects had too-short vectors.  Fixed.

TRT_ConditionsData: Fix out-of-bounds vector accesses.

See merge request !76776

Scott Snyder authored 2 months ago and Duc Ta committed 2 months ago

TRT_ConditionsData: Fix out-of-bounds vector accesses.

resize/reserve confusion.

BStoRDO: Store all ID BS errors

See merge request atlas/athena!76769

Rediuce memory requirements for ART tests

See merge request !76764

Tommaso Lari authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

Rediuce memory requirements for ART tests

Fix spurious PV warning in JetTagDQA

See merge request !76761

Thomas Strebler authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

Fix spurious PV warning in JetTagDQA

Add OverlayVertexSkimmingAlg

See merge request !76696

TrigConfxAOD: rename xAODMenuWriterMT to xAODMenuWriter

See merge request atlas/athena!76748

TrigSteeringEvent: Avoid out-of-bounds vector access.

See merge request !76707

Scott Snyder authored 2 months ago and Jiri Masik committed 2 months ago

TrigSteeringEvent: Avoid out-of-bounds vector access.

Truncation_test was failing when build with -D_GLIBCXX_ASSERTIONS.

Switch 2 L1 jTAU multiplicity algorithms to cTAUs

See merge request !76612

Jean Yves Beaucamp authored 2 months ago and Jiri Masik committed 2 months ago

Switch 2 L1 jTAU multiplicity algorithms to cTAUs

L1CaloFEXByteStream: Fix out-of-bounds array accesses.

See merge request !76699

Scott Snyder authored 2 months ago and Jiri Masik committed 2 months ago

L1CaloFEXByteStream: Fix out-of-bounds array accesses.

Unused fibers are marked with *_NFI[i] == -1.
Need to skip those rather than trying to use that as an index.
Solves crashes seen when building with -D_GLIBCXX_ASSERTIONS.

eflowRec: Fix use of invalid iterators.

See merge request !76712

Scott Snyder authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

eflowRec: Fix use of invalid iterators.

annihilateCluster was looping though a vector, erasing each element in turn,
in order to clear the vector.
Not only is this ineffient, it ends up using invalid iterators.
This was causing a crash with gcc15.
Just change to using clear().

CaloRec: Fix cppcheck warning.

See merge request !76720

Scott Snyder authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

CaloRec: Fix cppcheck warning.

nextCelIterEnd gets invalidated on erase().

ZdcNtuple: Fix cppcheck warning.

See merge request !76745

Scott Snyder authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

ZdcNtuple: Fix cppcheck warning.

Potential null pointer dereference.

CxxUtils: Avoid out-of-bounds vector reference.

See merge request !76708

Scott Snyder authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

CxxUtils: Avoid out-of-bounds vector reference.

Fix calculation of end iterator to avoid dereferencing.
Fixes crash seen when building with -D_GLIBCXX_ASSERTIONS.

TrkVertexSeedFinderUtils: Fix out-of-bounds vector access.

See merge request !76706

Scott Snyder authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

TrkVertexSeedFinderUtils: Fix out-of-bounds vector access.

In these lines
```
        std::vector< std::pair< int, int> > idxprevious = (*idxs)[splt-1] ;
        offset = idxprevious[sz].second ;
```

we seem to want to refer to the last element in idxprevious.
But sz is the size of (*idxs)[split], so this can result in
an out-of-bounds access.  Changed to use back().
Also get rid of some needless vector copies.
Fixes crash when compiling with -D_GLIBCXX_ASSERTIONS.

TrackOverlayRec: Cleanup CMakeLists.txt

See merge request !76689

Remove unused OverlayByteStreamUtils

See merge request !76688

LArSuperCellMon HLT configuration and chain definition

See merge request atlas/athena!76454

Denis Oliveira Damazio authored 2 months ago and Jiri Masik committed 2 months ago

Fix for some small mistakes in the LArSuperCellMonAlg configuration and update input file to be used