RTA Shift Summary 22/11/2021 - 6/12/2021
RTA shifter: Lorenzo Pica (@lpica)
RTA maintainer: Rosen Matev (@rmatev) and Sebastien Ponce (@sponce)
Shift period: 22/11/2021 - 6/12/2021
All MRs, both open and merged, managed by me and Alessandro on the past shift period can be found in the Google document https://docs.google.com/spreadsheets/d/1W8Z3GxA-Snw1RzKeYqRSfXshpoQa60YPROEKIH5BdKQ/edit#gid=495308620.
| Description | MR | Status | Next action |
|---|---|---|---|
| fix monitoringIDs in FTChannelID | LHCb!3325 (merged) | Marked as ready | Asked for review |
| Draft: Add Hlt2 BandQ ccbar to ppbar lines | !1148 (merged) | Draft at the moment | Probably ready to be tested soon |
| template floating-point type in TMV_utils | Rec!2640 (merged) | Tests passed | Asked for merging |
| B2OC: Add 308 new lines, enhancements and fixes | !1199 (merged) | Ready | Wait physics review (merged before xmas break if possible) |
| Dev christina routingbits | Allen!689 (merged) | Reviewed | Asked if needs additional review, test otherwise |
| SOACollection's proxy features | Phys!1018 (merged) LHCb!3333 (merged) Rec!2628 (merged) | Tested, somme diffs present | Investigate diffs |
| Added support for compressed MDF in IOAlg | LHCb!3347 (merged) | lhcb-head testing | Check test result |
| Change doubles to floats in calo event model | Rec!2636 (merged) LHCb!3348 (merged) | Comments going on | Wait |
| Fix conflict between !1173 (merged) and !1175 (merged) | !1198 (merged) | lhcb-head testing | Check test result |
| Update ganga.rst to use a current platform | !1197 (merged) | Asked for review | Wait |
| Change config.py to avoid problems with online output | !1196 (merged) | Tests passed | Asked for merging |
| IConditionDerivationMgr - Extend type checks to handle CopyWrapper | LHCb!3346 (merged) | Tests passed | Asked for merging |
| RichDAQ - Decoding fixes when inactive links are present | LHCb!3300 (merged) | Tests passed | Asked for merging |
| Add tests to check hlt2 output files | !1158 (merged) | Tests passed | Asked for merging |
| prototype of new alignment configuration | Alignment!203 (merged) | Tests failed | Wait Rosen's answer |
| Add ISID and ISABSID ThOr functors | Rec!2575 (merged) | Reviewed | Comments need to be addressed |
| RD common builders in the ThOr framework + new lines to test the builders (lines to be merged after selections update) | !1150 (merged) !1022 (merged) !1140 (merged) !1138 (merged) !1095 (merged) !1094 (merged) !1079 (merged) !1016 (merged) !1153 (merged) !1040 (merged) | Ci testing | Check tests result |
| Handling of missing fibers | LHCb!3342 (merged) | Partially reviewed | Wait for additional comments - otherwise ping or test |
| Augment Particle v1 to make it forward compatible with v2 - address #223: prefer ADL over if constexpr for customization | Rec!2631 (merged) LHCb!3338 (merged) | Tests passed | Asked for merging |
| B - > X l l - HLT2 lines | !1187 (merged) | Comments to be addressed (Draft at the moment) | Wait |
| Update standard_loki_thor_table.csv | !1185 (merged) | Ready | Wait for review |
| Throughput decrease checker; submit build $OPTIONS to grafana | Allen!722 (merged) | Comments to be addressed | Wait - ping if stuck |
| fix buffer overflow in AllenReportsToRawEvent and in UT track hits host buffer using gsl::span and safe_assign_to_host_buffer | Allen!708 (merged) | Reviewed | Wait for author |
| Adds PrConverters to convert between vectors of v1 and v2 RecVertex | Rec!2629 (merged) | Draft dependency | Comments going on |
| Large set of MRs with lots of dependencies | LHCb!3309 (merged) Rec!2607 (merged) Lbcom!588 (merged) Allen!704 (merged) LHCb!3343 (merged) Alignment!222 (merged) | ? | Ping if stuck |
| Add clone method to Flavourtag | LHCb!3332 (merged) | Reviewed (Draft at the moment) | Wait for author |
| FEST, HLT1 PRR and beam test - Remove environment fixes for Allen | Allen!650 (merged) !1170 (merged) | Comments going on | Wait or ping if stuck |
| Ported TMVATransform to TMVA.h | Rec!2588 (merged) | Draft | Wait |
| rich2 alignment line | Allen!717 (merged) | Asked for review | Ping reviewers if not responing |
SOA proxy: only allow const access to remote data |
LHCb!3326 (closed) | Draft at the moment | Wait |
| Bug fix and add functors FOURMOMENTUM, PX, PY, PZ and ENERGY | Rec!2619 (merged) | Kill ci test | Relaunch ci test |
| Initialise covariance with hit errors in VeloKalman | Allen!705 (closed) Rec!2612 (merged) | Author coming back | Wait |
| Updating SL lines with ThOr functors and adding new lines | !1151 (merged) | Comments need to be addressed | Wait |
| Create Allen run configuration for Allen wrappers | !609 (merged) | Works need to be done | Wait |
| Generate automatically StructToTuple.cuh as part of build | Allen!621 (merged) | Draft | Wait |
| B2CC: Migration to ThOr functors | !1070 (merged) | Draft | Wait |
| Potentially fix bug in configuration of TrackResChecker | !1015 (merged) | Works need to be done | Wait |
| RetinaClusters decoding | LHCb!3310 (merged) !1145 (merged) Allen!655 (merged) | Tested | Wait Rosen's review |
| New Event Data Algorithms | Rec!2537 (merged) | Draft dependency | Wait |
| add support for parsing vectors of enums in TrackEnums | LHCb!3324 (merged) Rec!2630 (merged) Rec!2565 (merged) | Ci testing !3324 and !2630 (closed) now | Check tests result |
| Add v7 FT decoding | LHCb!2942 (merged) | Comments going on | Wait - ping if stuck |
| Clean up logic for customising PyConf.Algorithm outputs | LHCb!3182 (merged) | Tests failed | Wait |
| Modernize MuonDet | LHCb!3188 (closed) | Some warning present | Wait |
| adjusted Alignment calls to FitNode 1D variants | Rec!2140 (merged) !983 (merged) Alignment!208 (merged) | Work ongoing - draft at the moment | Wait |
| track-based electron shower algorithm for improved electron PID | Rec!2319 (merged) !901 (merged) | Work going on (Draft) | Wait - ping if stuck |
| 3 body vertex fitter | Allen!422 (closed) | Draft | Wait |
| DD4Hep implementation of FT | Allen!698 (merged) LHCb!3264 (merged) Rec!2562 (merged) | Tested - ready for merging | Merge |
| Clustering for UT TELL40 decoding | Allen!607 (closed) | Draft dependency | Ping? |
| Assorted CI improvements | Allen!583 (closed) | Stuck | Close and open new one |
| make MuonID in hlt2 functional | !1141 (merged) Rec!2605 (merged) LHCb!3306 (merged) | Comments going on | Wait |
| speed up thor selections with fast distancecalculator | !1055 (closed) | Draft | Wait |
| Add Calo Clusters and Photon Line | Allen!683 (merged) | Fix needed | Wait |
Merged (or closed) MRs:
| Description | MR | Status | Next action |
|---|---|---|---|
| Temporary workaround to be able to use PatPV3D in default and fastest reconstruction | !1152 (merged) | ||
| Fix argument size setting in RICH1Line | Allen!719 (merged) | ||
| Update readme.md adding instructions for RetinaClusters (closed) | Allen!720 (closed) | ||
| Support sprucing in ProdConf | !1178 (merged) | ||
| Simple SV fit improvements | Allen!639 (merged) | ||
| Extended DeVP to be able to retrieve the module of a given sensor | LHCb!3339 (merged) | ||
| prefer prefix ++ for counters | Phys!1022 (merged) | ||
| GaudiException instead of crash when outside of a DVAlgorithm | Phys!1017 (merged) | ||
| Release the GIL so that XMLSummarySvc can acquire | LHCb!3340 (merged) | ||
| Converted TrackMuonUpgradeAlg Class to Functional Framework | Alignment!220 (merged) | ||
| Reco sequence without UT | !1175 (merged) | ||
| re-add gcc11 build to gitlab CI | Allen!716 (merged) | ||
| Added support for compressed MDF in IOAlg | LHCb!3335 (merged) | ||
| Add MASSWITHHYPOTHESES Thor/Loki Comparison | !1136 (merged) Rec!2583 (merged) Phys!1020 (merged) | ||
| Add check to make sure that all subdirs and source files are used | LHCb!3334 (merged) | ||
| clean up .gitignore for modern builds | Lbcom!592 (merged) | ||
| Use Gaudi::Units::MeV in Properties | Allen!703 (merged) | ||
| Calo monitoring Time Alignment and 2D histograms | Rec!2622 (merged) !1173 (merged) | ||
| Rename 'monitor' to 'check' | !1179 (merged) | ||
| BtoKee rmwillia (closed) | !1184 (closed) | ||
| Fixed compilation warning due to not checking if an std::optional properly (closed) | Allen!713 (closed) | ||
| New methods for PrFitNode + PrKalmanFilter as library and module | Rec!2603 (merged) | ||
| Fix check-formatting to use LbEnv | Rec!2627 (merged) | ||
| Add sanity checks to CaloClusterEfficiency | Lbcom!589 (merged) | ||
| Minor CMake configuration fix | Alignment!224 (merged) | ||
| Fix profile plots for VP, FT, UT hit monitors | Rec!2623 (merged) | ||
| Fix warning about unused cpp file | Rec!2626 (merged) | ||
| avoid foreshadowing | LHCb!3336 (merged) | ||
| Fix warning about unused cpp file | Rec!2626 (merged) | ||
| Fix compile error, extraploator using removed zips (follow up !2580 (merged)) | Rec!2624 (merged) | ||
| Apply GEC in HLT1RICH1Alignment line | Allen!721 (merged) | ||
| RICH 1 alignment line | Allen!687 (merged) | ||
| Check for warnings during CUDA builds in CI | Allen!669 (merged) | ||
| Expose states collection class | !1160 (merged) Rec!2580 (merged) LHCb!3291 (merged) | ||
| Fixed default version in PackTrack when nothing happens | LHCb!3328 (merged) | ||
| CI: Add a throughput job with contracts enabled | Allen!663 (merged) | ||
| Clearer validation of selection line names, HLT and Sprucing | !1172 (merged) | ||
| Remove LHCb mdf writer compression by default | LHCb!3331 (merged) | ||
| Remove deprecated use of Boost.bind | Phys!1014 (merged) | ||
| Follow up !687 (merged) (fix warning) | Allen!718 (merged) | ||
| SOACollection proxy simplification | LHCb!3323 (merged) Rec!2618 (merged) !1174 (merged) Brunel!1182 (merged) Phys!1012 (merged) | ||
| Enable MuonID by default following Rec!2599 (merged) | !1108 (merged) | ||
| Use selective_matching=True for lead-lead config | !1164 (merged) | ||
| Remove option to build without Allen | !1149 (merged) | ||
| Replace activation functions with faster versions and moving to floats in PID | !1157 (merged) Brunel!1179 (merged) Rec!2611 (merged) | ||
| Exit gracefully if no IDVAlgorithm is found (closed) | LHCb!3330 (closed) | ||
| Replace deprecated ToolHandle constuctor in MergedPi0 | Rec!2606 (merged) | ||
| DecayTreeFitterAlg to access refitted candidates | Phys!970 (merged) Rec!2504 (merged) | ||
| Ks-Line | Allen!551 (merged) |
Edited by Lorenzo Pica